-
Notifications
You must be signed in to change notification settings - Fork 12k
feat(@angular-devkit/build-angular): default to NodeJS value for pres… #16648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not sure if this is the right place to put this config, let me know if there's a better place to set it. |
I’m ok with using it as a default. However, it would be a breaking change since the default would be different for some people. This could manifest in either broken builds or builds containing different dependencies than anticipated or expected. As a feature, this would probably fall into the v10 timeframe. |
e3699cb
to
f5d55dd
Compare
@clydin Sounds good to me, how would we make sure to come back and check this when there's a v10 branch? |
@Toxicable, I can create a v10 milestone and assign this Pr to it. |
826bdc6
to
6105bf4
Compare
6105bf4
to
3282882
Compare
3282882
to
611a57c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Fabian! LGTM.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…erveSymlinks
Under bazel
preserveSymlinks
would have to be set in two different places, this makes it so it only has to be set once by using the value from NodeJS if it's set.